Skip to content

Disable HF Xet storage across all CI scripts#19371

Merged
rascani merged 1 commit intomainfrom
hf_disable_xf_part_2
May 7, 2026
Merged

Disable HF Xet storage across all CI scripts#19371
rascani merged 1 commit intomainfrom
hf_disable_xf_part_2

Conversation

@digantdesai
Copy link
Copy Markdown
Contributor

HuggingFace's Xet storage backend stalls mid-download on CI runners, causing 90-minute job timeouts. Set HF_HUB_DISABLE_XET=1 in every CI script and workflow that downloads from HuggingFace to force standard HTTP downloads instead.

HuggingFace's Xet storage backend stalls mid-download on CI runners,
causing 90-minute job timeouts. Set HF_HUB_DISABLE_XET=1 in every
CI script and workflow that downloads from HuggingFace to force
standard HTTP downloads instead.
@digantdesai digantdesai requested review from Copilot and rascani May 7, 2026 15:32
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19371

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Cancelled Job, 1 Pending, 3 Unrelated Failures

As of commit 23b6acb with merge base 1414bc1 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent CI timeouts caused by HuggingFace Hub’s Xet storage backend stalling mid-download by forcing standard HTTP downloads via HF_HUB_DISABLE_XET=1 in CI entrypoints that fetch models.

Changes:

  • Export HF_HUB_DISABLE_XET=1 in multiple CI shell scripts and in the MLX GitHub Actions workflow job scripts.
  • Set HF_HUB_DISABLE_XET early in .ci/scripts/test_huggingface_optimum_model.py to cover downloads triggered by Python-based HF/Optimum flows.
  • Add the env var in .ci/scripts/download_hf_hub.sh to cover callers of the shared HF download helper.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/mlx.yml Exports HF_HUB_DISABLE_XET=1 in several MLX workflow job scripts before model downloads.
.ci/scripts/test_phi_3_mini.sh Disables Xet to avoid stalled HF downloads during Phi-3 mini CI flows.
.ci/scripts/test_lora.sh Disables Xet for LoRA tests that download from HuggingFace Hub.
.ci/scripts/test_lora_multimethod.sh Disables Xet for multimethod LoRA tests that download from HuggingFace Hub.
.ci/scripts/test_huggingface_optimum_model.py Sets HF_HUB_DISABLE_XET in-process before importing libs that may trigger HF downloads.
.ci/scripts/export_model_artifact.sh Disables Xet for model export flows that snapshot-download from HuggingFace Hub.
.ci/scripts/download_hf_hub.sh Disables Xet for all HF downloads performed via this helper script.
Comments suppressed due to low confidence (1)

.ci/scripts/export_model_artifact.sh:74

  • This script exports HF_HUB_DISABLE_XET before enabling set -u, but it only validates $1 and then later reads $2 (HF model) unconditionally. Running with a missing hf_model will fail with an unbound variable error, and the earlier error message also refers to the wrong argument. Consider validating both required args (device + hf_model) before set -u and updating the error message accordingly.
# Disable HF Xet storage to avoid stalled downloads on CI runners
export HF_HUB_DISABLE_XET=1

set -eux


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/mlx.yml
Comment on lines 307 to 311
script: |
set -eux
# Disable HF Xet storage to avoid stalled downloads on CI runners
export HF_HUB_DISABLE_XET=1

Comment on lines 1 to +5
#!/bin/bash

# Disable HF Xet storage to avoid stalled downloads on CI runners
export HF_HUB_DISABLE_XET=1

@rascani
Copy link
Copy Markdown
Contributor

rascani commented May 7, 2026

Failures seem unrelated.

@rascani rascani merged commit 1643611 into main May 7, 2026
363 of 370 checks passed
@rascani rascani deleted the hf_disable_xf_part_2 branch May 7, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants